diff options
| author | sfan5 <sfan5@live.de> | 2017-05-13 11:34:20 +0200 |
|---|---|---|
| committer | sfan5 <sfan5@live.de> | 2017-05-13 11:51:36 +0200 |
| commit | 38e9b42caf66d6ee1e78bfc27b98c6d131c4d1b9 (patch) | |
| tree | 6032f50f1399a09215f505d2cc5cb30ff3075c0b | |
| parent | ea465f8fe430ee8d0c6e597bdfb180a8de1ca3a6 (diff) | |
Do not allow any worldedit_gui commands without privs
| -rw-r--r-- | worldedit_gui/init.lua | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/worldedit_gui/init.lua b/worldedit_gui/init.lua index 0a770c6..12157b5 100644 --- a/worldedit_gui/init.lua +++ b/worldedit_gui/init.lua @@ -14,7 +14,7 @@ Use `nil` for the `options` parameter to unregister the function associated with Use `nil` for the `get_formspec` field to denote that the function does not have its own screen. -Use `nil` for the `privs` field to denote that no special privileges are required to use the function. +The `privs` field may not be `nil`. If the identifier is already registered to another function, it will be replaced by the new one. @@ -24,6 +24,9 @@ The `on_select` function must not call `worldedit.show_page` worldedit.pages = {} --mapping of identifiers to options local identifiers = {} --ordered list of identifiers worldedit.register_gui_function = function(identifier, options) + if options.privs == nil or next(options.privs) == nil then + error("privs unset") + end worldedit.pages[identifier] = options table.insert(identifiers, identifier) end @@ -46,7 +49,7 @@ worldedit.register_gui_handler = function(identifier, handler) --ensure the player has permission to perform the action local entry = worldedit.pages[identifier] - if entry and minetest.check_player_privs(name, entry.privs or {}) then + if entry and minetest.check_player_privs(name, entry.privs) then return handler(name, fields) end return false @@ -272,7 +275,7 @@ worldedit.register_gui_handler("worldedit_gui", function(name, fields) for identifier, entry in pairs(worldedit.pages) do --check for WorldEdit GUI main formspec button selection if fields[identifier] and identifier ~= "worldedit_gui" then --ensure player has permission to perform action - local has_privs, missing_privs = minetest.check_player_privs(name, entry.privs or {}) + local has_privs, missing_privs = minetest.check_player_privs(name, entry.privs) if not has_privs then worldedit.player_notify(name, "you are not allowed to use this function (missing privileges: " .. table.concat(missing_privs, ", ") .. ")") return false |